Apr. 12th, 2005 @ 02:57 am
|Date:||April 15th, 2005 04:00 pm (UTC)|| |
|(Link)|Would it be possible to adapt your code to other S2 layouts, do you think?
Yes, it should be relatively easy for layouts that are largely core-based for the comment placement. I've talked about it a little bit before this, but I should probably do a full write-up in lj_style
now that this contest has drummed up a bit of interest!
That would be cool, if you could explain a bit how your chronological comment thing works. I'm completely in love with the concept.
Also, I've been playing around with your style on my journal recently, and I have a couple of comments. Still really like it, but I've turned up a couple of minor flaws. Firstly, you haven't set your style to public; is that intentional? I had to copy and paste your code into a style of my own to be able to use it. And that means I can't use your themes (except by copying and pasting the code for them as well.)
The other one is the ability to change the font face and size. That's the first thing most users want to customize on any style, (other than background images which you have catered quite nicely). It's the quickest way to make your journal look 'non-default', and more than that, it can be an accessibility issue. For example, some people are visually impaired and can only read certain font combinations on screen or need a minimum size. I appreciate you could do it in a theme layer with CSS, but my opinion is that it's basic enough that it should be in the wizard. Just my thoughts.
Also, how would you feel about my playing around with your code to make it more CSS-able? Because people are always going to come up with customizations you haven't thought of in the wizard. There are a couple of places I've spotted where more named classes would be a real help with flexibility.
|Date:||April 18th, 2005 04:08 pm (UTC)|| |
|(Link)|Firstly, you haven't set your style to public; is that intentional?
No, that was a complete oversight -- thank you for pointing it out.The first is the ability to choose whether you want custom comments or not.
Again, that must have been an oversight on my part; I'll add that in. (Fortunately, that's quite simple!)The other one is the ability to change the font face and size.
This would be a good feature to add in, I agree.Also, how would you feel about my playing around with your code to make it more CSS-able? Because people are always going to come up with customizations you haven't thought of in the wizard. There are a couple of places I've spotted where more named classes would be a real help with flexibility.
I'm assuming that if this style is accepted for public use, there will be a period in which it is cleaned up before it is made available. I would greatly appreciate your assistance! (And if it isn't, well, people still might want it as a custom style, in which case they'll be likely to want those customizable featuers even more
.) Thank you very much!
|Date:||May 2nd, 2005 09:52 pm (UTC)|| |
I've set up a community widelines
for this style and put up a version of the code which contains some bug fixes, new features, and cleaner code.
There's been some talk on news
about accepting all of the submitted styles for public use, but I have not been contacted yet about this. In any event, I would love to see how you'd like to extend the code.
|Top of Page
||Powered by LiveJournal.com|